8000 Improve the documentation of `Finder::exclude()` by mnapoli · Pull Request #26396 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Improve the documentation of Finder::exclude() #26396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2018
Merged

Improve the documentation of Finder::exclude() #26396

merged 1 commit into from
Mar 4, 2018

Conversation

mnapoli
Copy link
Contributor
@mnapoli mnapoli commented Mar 4, 2018
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Tried to do this and this didn't work:

$iterator->in($sourcePath)
    ->exclude($sourcePath.'/foo');

I read on http://symfony.com/doc/current/components/finder.html that excluded directories need to be relative:

capture d ecran 2018-03-04 a 16 10 31

@chalasr chalasr added the Finder label Mar 4, 2018
@chalasr chalasr added this to the 2.7 milestone Mar 4, 2018
@fabpot
Copy link
Member
fabpot commented Mar 4, 2018

Thank you @mnapoli.

@fabpot fabpot merged commit cc3084e into symfony:2.7 Mar 4, 2018
fabpot added a commit that referenced this pull request Mar 4, 2018
@fabpot
minor #26396 Improve the documentation of Finder::exclude() (mnapoli)
3379310 
This PR was merged into the 2.7 branch.

Discussion
----------

Improve the documentation of `Finder::exclude()`

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

Tried to do this and this didn't work:

```php
$iterator->in($sourcePath)
    ->exclude($sourcePath.'/foo');
```

I read on http://symfony.com/doc/current/components/finder.html that excluded directories need to be relative:

![capture d ecran 2018-03-04 a 16 10 31](https://user-images.githubusercontent.com/720328/36947055-28e47eda-1fc7-11e8-9475-399a3d853169.png)

Commits
-------

cc3084e Improve the documentation of `Finder::exclude()`
@mnapoli mnapoli deleted the patch-1 branch March 4, 2018 19:03
@xabbuh xabbuh mentioned this pull request Mar 5, 2018
Closed
joshtrichards added a commit to joshtrichards/symfony that referenced this pull request Apr 26, 2024
@joshtrichards
fix(Finder): ExcludeDirectoryFilterIterator relative to root-only if /
fdb772f 
Fixes symfony#28158
Fixes symfony#47431

Related: symfony#26396
Related: symfony#9158
Related: symfony#28410
joshtrichards added a commit to joshtrichards/symfony that referenced this pull request Apr 27, 2024
@joshtrichards
fix(Finder): ExcludeDirectoryFilterIterator relative to "root" if /
3aeedb6 
Fixes symfony#28158
Fixes symfony#47431

Related: symfony#26396
Related: symfony#9158
Related: symfony#28410
@joshtrichards joshtrichards mentioned this pull request Apr 27, 2024
Open
joshtrichards added a commit to joshtrichards/symfony that referenced this pull request Apr 27, 2024
@joshtrichards
fix(Finder): ExcludeDirectoryFilterIterator relative to "root" if /
d685583 
Fixes symfony#28158
Fixes symfony#47431

Related: symfony#26396
Related: symfony#9158
Related: symfony#28410
phil-davis pushed a commit to phil-davis/symfony that referenced this pull request Apr 27, 2024
@joshtrichards @phil-davis
fix(Finder): ExcludeDirectoryFilterIterator relative to "root" if /
21753f2 
Fixes symfony#28158
Fixes symfony#47431

Related: symfony#26396
Related: symfony#9158
Related: symfony#28410
phil-davis pushed a commit to phil-davis/symfony that referenced this pull request Apr 27, 2024
@joshtrichards @phil-davis
fix(Finder): ExcludeDirectoryFilterIterator relative to "root" if /
01045da 
Fixes symfony#28158
Fixes symfony#47431

Related: symfony#26396
Related: symfony#9158
Related: symfony#28410
phil-davis pushed a commit to phil-davis/symfony that referenced this pull request Apr 27, 2024
@joshtrichards @phil-davis
fix(Finder): ExcludeDirectoryFilterIterator relative to "root" if /
bb54e8b 
Fixes symfony#28158
Fixes symfony#47431

Related: symfony#26396
Related: symfony#9158
Related: symfony#28410
phil-davis pushed a commit to phil-davis/symfony that referenced this pull request Aug 9, 2024
@joshtrichards @phil-davis
fix(Finder): ExcludeDirectoryFilterIterator relative to "root" if /
f144128 
Fixes symfony#28158
Fixes symfony#47431

Related: symfony#26396
Related: symfony#9158
Related: symfony#28410
phil-davis pushed a commit to phil-davis/symfony that referenced this pull request Aug 9, 2024
@joshtrichards @phil-davis
fix(Finder): ExcludeDirectoryFilterIterator relative to "root" if /
5349a03 
Fixes symfony#28158
Fixes symfony#47431

Related: symfony#26396
Related: symfony#9158
Related: symfony#28410
phil-davis pushed a commit to phil-davis/symfony that referenced this pull request Aug 11, 2024
@joshtrichards @phil-davis
fix(Finder): ExcludeDirectoryFilterIterator relative to "root" if /
cf6121e 
Fixes symfony#28158
Fixes symfony#47431

Related: symfony#26396
Related: symfony#9158
Related: symfony#28410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@ro0NL ro0NL ro0NL approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Finder Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@mnapoli @fabpot @ro0NL @chalasr @carsonbot
0