8000 [FrameworkBundle] show the unregistered command warning at the end of the list command by Simperfit · Pull Request #26288 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] show the unregistered command warning at the end of the list command #26288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2018
Merged

[FrameworkBundle] show the unregistered command warning at the end of the list command #26288

merged 1 commit into from
Mar 15, 2018

Conversation

Simperfit
Copy link
Contributor
@Simperfit Simperfit commented Feb 23, 2018 •
edited
Loading
Q A
Branch? 4.1
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26203
License MIT
Doc PR I don't think we need one.

This PR modify the warning error when you have unregistered command on the list command, it shows it at the end.

@Simperfit Simperfit force-pushed the feature/show-unregistered-warning-at-the-end branch from 1d01cb1 to 9513d04 Compare February 23, 2018 14:37
chalasr
chalasr requested changes Feb 23, 2018
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Console/Application.php Outdated
@@ -77,11 +78,17 @@ public function doRun(InputInterface $input, OutputInterface $output)
*/
protected function doRunCommand(Command $command, InputInterface $input, OutputInterface $output)
{
$parentRun = parent::doRunCommand($command, $input, $output);
Copy link
Member
@chalasr chalasr Feb 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually runs the command thus writes to the output no matter which command is ran, not good, should be called at the right place (don't assign)

@Simperfit Simperfit force-pushed the feature/show-unregistered-warning-at-the-end branch 5 times, most recently from 6547e37 to 9302a4a Compare February 23, 2018 15:37
@Simperfit
Copy link
Contributor Author

Status: Needs Review

@Simperfit Simperfit force-pushed the feature/show-unregistered-warning-at-the-end branch 4 times, most recently from f6c7756 to 541f33d Compare February 24, 2018 09:56
@chalasr chalasr added this to the 4.1 milestone Feb 24, 2018
@Simperfit Simperfit force-pushed the feature/show-unregistered-warning-at-the-end branch from 541f33d to 9e0dfc3 Compare March 2, 2018 12:19
@Simperfit
< 8000 span data-view-component="true"> Copy link
Contributor Author

PR rebased

@fabpot
Copy link
Member
fabpot commented Mar 10, 2018

Looks like some tests do not pass as a consequence of this change.

@Simperfit Simperfit force-pushed the feature/show-unregistered-warning-at-the-end branch from 9e0dfc3 to 99b104a Compare March 14, 2018 11:20
@fabpot
Copy link
Member
fabpot commented Mar 15, 2018

Thank you @Simperfit.

@fabpot fabpot merged commit 99b104a into symfony:master Mar 15, 2018
fabpot added a commit that referenced this pull request Mar 15, 2018
@fabpot
feature #26288 [FrameworkBundle] show the unregistered command warnin…
bf120d0 
…g at the end of the list command (Simperfit)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[FrameworkBundle] show the unregistered command warning at the end of the list command

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | no
| New feature?  | yes   <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no   <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26203  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | I don't think we need one.

This PR modify the warning error when you have unregistered command on the list command, it shows it at the end.

Commits
-------

99b104a [FrameworkBundle] show the unregistered command warning at the end of the list command
@Simperfit Simperfit deleted the feature/show-unregistered-warning-at-the-end branch March 15, 2018 16:50
@fabpot fabpot mentioned this pull request May 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Simperfit @fabpot @chalasr @carsonbot
0