8000 [Console] fix console test by Simperfit · Pull Request #26282 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] fix console test #26282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2018
Merged

[Console] fix console test #26282

merged 1 commit into from
Feb 23, 2018

Conversation

Simperfit
Copy link
Contributor
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR none

It seems that tests are broken due to missing spaces.

@chalasr
Copy link
Member
chalasr commented Feb 23, 2018

The change breaks travis which is currently green, I suggest to trim in the assertion.

@Simperfit Simperfit force-pushed the hotfix/fix-console-test branch 2 times, most recently from 4260c4c to bebf7ec Compare February 23, 2018 13:01
@Simperfit Simperfit force-pushed the hotfix/fix-console-test branch from bebf7ec to 965e472 Compare February 23, 2018 13:20
@chalasr
Copy link
Member
chalasr commented Feb 23, 2018

Thank you Hamza.

@xabbuh xabbuh added this to the 4.1 milestone Feb 23, 2018
@chalasr chalasr merged commit 965e472 into symfony:master Feb 23, 2018
chalasr added a commit that referenced this pull request Feb 23, 2018
@chalasr
minor #26282 [Console] fix console test (Simperfit)
7be0ccc 
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Console] fix console test

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none

It seems that tests are broken due to missing spaces.

Commits
-------

965e472 [Console] fix console test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Simperfit @chalasr @xabbuh @carsonbot
0