10000 [PropertyInfo] Move phpDocumentor to require section by hkdobrev · Pull Request #26260 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyInfo] Move phpDocumentor to require section #26260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[PropertyInfo] Move phpDocumentor to require section #26260

wants to merge 1 commit into from

Conversation

hkdobrev
Copy link
Contributor
@hkdobrev hkdobrev commented Feb 21, 2018 •
edited
Loading
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26259
License MIT
Doc PR N/A

@hkdobrev hkdobrev changed the title Move phpDocument to require section [PropertyInfo] Move phpDocument to require section Feb 21, 2018
@hkdobrev hkdobrev changed the title [PropertyInfo] Move phpDocument to require section [PropertyInfo] Move phpDocumentor to require section Feb 21, 2018
@hkdobrev hkdobrev mentioned this pull request Feb 22, 2018
Merged
@hkdobrev
Copy link
Contributor Author

@jvasseur Hi! Thanks for taking a look at this! Would you mind adding a comment? I'm keen to see other solutions to #26259 (comment)

@jvasseur
Copy link
Contributor

I'm 👎 because this is not the solution to the problem, the propertyinfo component can work without any problems when reflection-docblock is not installed if you don't use the PhpDocExtractor.

#26265 is probably the best solution we have.

The cleanest solution would be to move the PhpDocExtractor to a separate package that has the dependency on reflection-docblock (if you want to use PHPDoc extraction you require it and you get all you need). But that's not a good solution in the long run: we have tons of classes in the same situation, and that result in a lot of packages to maintains (and a lot of packages to require when developing).

@fabpot
Copy link
Member
fabpot commented Feb 22, 2018

closing in favor of #26265

@fabpot fabpot closed this Feb 22, 2018
@hkdobrev hkdobrev deleted the property-info-phpdocumentor branch February 22, 2018 11:01
@lamasfoker lamasfoker mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hkdobrev @jvasseur @fabpot @carsonbot
0