8000 [Routing] Fix suffix aggregation by nicolas-grekas · Pull Request #26253 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Fix suffix aggregation #26253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2018
Merged

[Routing] Fix suffix aggregation #26253

merged 1 commit into from
Feb 21, 2018

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Feb 21, 2018
nicolas-grekas
nicolas-grekas commented Feb 21, 2018
View reviewed changes
src/Symfony/Component/Routing/Tests/Fixtures/dumper/url_matcher12.php Outdated
.'|/10(?'
.'|(*:70)'
.'|0(*:78)'
.')'
Copy link
Member Author
@nicolas-grekas nicolas-grekas Feb 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this change, a list is generated instead of a tree:

                        .'|/2(*:33)'
                        .'|/10(*:43)'
                        .'|/20(*:53)'
                        .'|/100(*:64)'
                        .'|/200(*:75)'

nicolas-grekas
nicolas-grekas commented Feb 21, 2018
View reviewed changes
src/Symfony/Component/Routing/Tests/Fixtures/dumper/url_matcher12.php
.'|0(*:79)'
.')'
.')'
.')'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this change, a list is generated instead of a tree:

                        .'|/2(*:33)'
                        .'|/10(*:43)'
                        .'|/20(*:53)'
                        .'|/100(*:64)'
                        .'|/200(*:75)'

@fabpot
Copy link
Member
fabpot commented Feb 21, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 1466597 into symfony:master Feb 21, 2018
fabpot added a commit that referenced this pull request Feb 21, 2018
@fabpot
bug #26253 [Routing] Fix suffix aggregation (nicolas-grekas)
cf045c0 
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Routing] Fix suffix aggregation

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

1466597 [Routing] Fix suffix aggregation
@nicolas-grekas nicolas-grekas deleted the route-suffix branch February 21, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Bug Routing Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @Simperfit @carsonbot
0