8000 Document the container.autowiring.strict_mode option by B-Galati · Pull Request #26251 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Document the container.autowiring.strict_mode option #26251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

B-Galati
Copy link
Contributor
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets symfony/symfony-docs#8561
License MIT
Doc PR no

Hello,

Let me know for any misunderstanding from my part or rewording

UPGRADE-4.0.md Outdated

```yml
parameters:
container.autowiring.strict_mode: true
Copy link
Contributor
@ro0NL ro0NL Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent by 4 spaces for consistency :)

UPGRADE-4.0.md Outdated
* Autowiring services based on the types they implement is not supported anymore. Rename (or alias) your services to their FQCN id to make them autowirable.
* Autowiring services based on the types they implement is not supported anymore.
It will only look for an alias or a service id that matches a given FQCN. Rename (or alias) your services to their FQCN id to make them autowirable.
In 3.4, you can activate this behavior instead of having deprecation messages by setting the following parameter :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space before : to be removed.

UPGRADE-4.0.md Outdated
container.autowiring.strict_mode: true
```

From 4.0, you can remove it as it's the default behavior and the parameters is not handled anymore.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: parameter instead of parameters.

UPGRADE-4.0.md Outdated
@@ -163,7 +163,16 @@ DependencyInjection
autowire: true
```

* Autowiring services based on the types they implement is not supported anymore. Rename (or alias) your services to their FQCN id to make them autowirable.
* Autowiring services based on the types they implement is not supported anymore.
It will only look for an alias or a service id that matches a given FQCN. Rename (or alias) your services to their FQCN id to make them autowirable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wrap at 80 chars?

@B-Galati B-Galati force-pushed the document-autowire-strict-mode branch from b0005cf to 1138377 Compare February 21, 2018 21:16
@B-Galati
Copy link
Contributor Author

@fabpot @ro0NL Done, thank you !

@fabpot
Copy link
Member
fabpot commented Feb 22, 2018

Thank you @B-Galati.

@fabpot fabpot merged commit 1138377 into symfony:3.4 Feb 22, 2018
fabpot added a commit that referenced this pull request Feb 22, 2018
…Galati)

This PR was merged into the 3.4 branch.

Discussion
----------

Document the container.autowiring.strict_mode option

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/symfony-docs#8561
| License       | MIT
| Doc PR        | no

Hello,

Let me know for any misunderstanding from my part  or rewording

Commits
-------

1138377 Document the container.autowiring.strict_mode option
fabpot added a commit that referenced this pull request Feb 23, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

add container.autowiring.strict_mode to 3.4 docs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

#26251 was a nice step, but IMO we need to add some docs to the 3.4 upgrade docs too as this is where people are probably looking first.

Commits
-------

4d973c2 add container.autowiring.strict_mode to 3.4 docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0