[PropertyInfo] ReflectionExtractor: give a chance to other extractors if no properties #26236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if no properties
|
Looks good to me |
stof
approved these changes
Feb 19, 2018
nicolas-grekas
approved these changes
Feb 19, 2018
Simperfit
approved these changes
Feb 19, 2018
fabpot
approved these changes
Feb 19, 2018
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Feb 19, 2018
… extractors if no properties (dunglas) This PR was merged into the 2.8 branch. Discussion ---------- [PropertyInfo] ReflectionExtractor: give a chance to other extractors if no properties | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #25803 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | n/a For instance when using `__call()`, see #25803. <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Replace this comment by a description of what your PR is solving. --> Commits ------- 270147b [PropertyInfo] ReflectionExtractor: give a chance to other extractors if no properties
This was referenced Mar 1, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance when using
__call(), see #25803.