8000 [FrameworkBundle] Add command to delete an item from a cache pool by pierredup · Pull Request #26223 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] Add command to delete an item from a cache pool #26223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bundle\FrameworkBundle\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use Symfony\Component\HttpKernel\CacheClearer\Psr6CacheClearer;

/**
* Delete an item from a cache pool.
*
* @author Pierre du Plessis <pdples@gmail.com>
*/
final class CachePoolDeleteCommand extends Command
{
protected static $defaultName = 'cache:pool:delete';

private $poolClearer;

public function __construct(Psr6CacheClearer $poolClearer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to inject the cache clearer to then use it to fetch a pool? Shouldn't we rather inject the pools directly?

{
parent::__construct();

$this->poolClearer = $poolClearer;
}

/**
* {@inheritdoc}
*/
protected function configure()
{
$this
->setDefinition(array(
new InputArgument('pool', InputArgument::REQUIRED, 'The cache pool from which to delete an item'),
new InputArgument('key', InputArgument::REQUIRED, 'The cache key to delete from the pool'),
))
->setDescription('Deletes an item from a cache pool')
->setHelp(<<<'EOF'
The <info>%command.name%</info> deletes an item from a given cache pool.

%command.full_name% <pool> <key>
EOF
)
;
}

/**
* {@inheritdoc}
*/
protected function execute(InputInterface $input, OutputInterface $output)
{
$io = new SymfonyStyle($input, $output);
$pool = $input->getArgument('pool');
$key = $input->getArgument('key');
$cachePool = $this->poolClearer->getPool($pool);

if (!$cachePool->hasItem($key)) {
$io->note(sprintf('Cache item "%s" does not exist in cache pool "%s".', $key, $pool));

return;
}

if (!$cachePool->deleteItem($key)) {
throw new \Exception(sprintf('Cache item "%s" could not be deleted.', $key));
}

$io->success(sprintf('Cache item "%s" was successfully deleted.', $key));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@
<tag name="console.command" command="cache:pool:prune" />
</service>

<service id="console.command.cache_pool_delete" class="Symfony\Bundle\FrameworkBundle\Command\CachePoolDeleteCommand">
<argument type="service" id="cache.global_clearer" />
<tag name="console.command" command="cache:pool:delete" />
</service>

<service id="console.command.cache_warmup" class="Symfony\Bundle\FrameworkBundle\Command\CacheWarmupCommand">
<argument type="service" id="cache_warmer" />
<tag name="console.command" command="cache:warmup" />
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bundle\FrameworkBundle\Tests\Command;

use Psr\Cache\CacheItemPoolInterface;
use Symfony\Bundle\FrameworkBundle\Command\CachePoolDeleteCommand;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Bundle\FrameworkBundle\Tests\TestCase;
use Symfony\Component\Console\Tester\CommandTester;
use Symfony\Component\HttpKernel\CacheClearer\Psr6CacheClearer;
use Symfony\Component\HttpKernel\KernelInterface;

class CachePoolDeleteCommandTest extends TestCase
{
private $cachePool;

protected function setUp()
{
$this->cachePool = $this->getMockBuilder(CacheItemPoolInterface::class)
->getMock();
}

public function testCommandWithValidKey()
{
$this->cachePool->expects($this->once())
->method('hasItem')
->with('bar')
->willReturn(true);

$this->cachePool->expects($this->once())
->method('deleteItem')
->with('bar')
->willReturn(true);

$tester = $this->getCommandTester($this->getKernel());
$tester->execute(array('pool' => 'foo', 'key' => 'bar'));

$this->assertContains('[OK] Cache item "bar" was successfully deleted.', $tester->getDisplay());
}

public function testCommandWithInValidKey()
{
$this->cachePool->expects($this->once())
->method('hasItem')
->with('bar')
->willReturn(false);

$this->cachePool->expects($this->never())
->method('deleteItem')
->with('bar');

$tester = $this->getCommandTester($this->getKernel());
$tester->execute(array('pool' => 'foo', 'key' => 'bar'));

$this->assertContains('[NOTE] Cache item "bar" does not exist in cache pool "foo".', $tester->getDisplay());
}

public function testCommandDeleteFailed()
{
$this->cachePool->expects($this->once())
->method('hasItem')
->with('bar')
->willReturn(true);

$this->cachePool->expects($this->once())
->method('deleteItem')
->with('bar')
->willReturn(false);

if (method_exists($this, 'expectExceptionMessage')) {
$this->expectExceptionMessage('Cache item "bar" could not be deleted.');
} else {
$this->setExpectedException('Exception', 'Cache item "bar" could not be deleted.');
}

$tester = $this->getCommandTester($this->getKernel());
$tester->execute(array('pool' => 'foo', 'key' => 'bar'));
}

/**
* @return \PHPUnit_Framework_MockObject_MockObject|KernelInterface
*/
private function getKernel()
{
$container = $this
->getMockBuilder('Symfony\Component\DependencyInjection\ContainerInterface')
->getMock();

$kernel = $this
->getMockBuilder(KernelInterface::class)
->getMock();

$kernel
->expects($this->any())
->method('getContainer')
->willReturn($container);

$kernel
->expects($this->once())
->method('getBundles')
->willReturn(array());

return $kernel;
}

private function getCommandTester(KernelInterface $kernel): CommandTester
{
$application = new Application($kernel);
$application->add(new CachePoolDeleteCommand(new Psr6CacheClearer(array('foo' => $this->cachePool))));

return new CommandTester($application->find('cache:pool:delete'));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@ public function hasPool($name)
return isset($this->pools[$name]);
}

public function getPool($name)
{
if (!$this->hasPool($name)) {
throw new \InvalidArgumentException(sprintf('Cache pool not found: %s.', $name));
}

return $this->pools[$name];
}

public function clearPool($name)
{
if (!isset($this->pools[$name])) {
Expand Down
0