8000 Also identify FirePHP by the X-FirePHP-Version header by schniper · Pull Request #2620 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Also identify FirePHP by the X-FirePHP-Version header #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Also identify FirePHP by the X-FirePHP-Version header #2620

wants to merge 1 commit into from

Conversation

schniper
Copy link
Contributor

ZF also received this update a while back.
The Chrome FirePHP extension, for example, sets this header instead of altering the user agent.

@Seldaek
Copy link
Member
Seldaek commented Nov 11, 2011

Good to know, can you fix that in Monolog's FirePHPHandler too?

@schniper
Copy link
Contributor Author

If I figure how to fetch the headers from that method :)

@Seldaek
Copy link
Member
Seldaek commented Nov 11, 2011

Just use $_SERVER['HTTP_X_FIREPHP_VERSION']

@schniper
Copy link
Contributor Author

Right, just found it. Was looking for ['X_FIREPHP_VERSION']...

@stof
Copy link
Member
stof commented Nov 11, 2011

@schniper As it is a bugfix, can you do a PR against the 2.0 branch instead ?

@stof
Copy link
Member
stof commented Nov 11, 2011

Closing this one as #2622 replaces it

@stof stof closed this Nov 11, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0