Ticket 25999 #26013
Ticket 25999 #26013
Conversation
There was a problem hiding this comment.
To fix the changes in a lower branch, you'll have to make different pull requests. Find the lowest maintained branch (2.7 in this case) that supports your patch for those lines and base the pull request on that branch. You mentioned that the ReflectionClassResource does not exist in 2.7 yet, so those changes need to be applied in a higher branch than 2.7 (meaning multiple pull requests).
| * 3.4.x (2018-xx-xx) | ||
|
|
||
| * bug #25999 [DependencyInjection] Huge performance degradation of ReflectionClassResource and FileResource on big projects inside Docker For Mac | ||
|
|
There was a problem hiding this comment.
This file is updated automatically when a new symfony version is released. Can you please revert this change?
| return file_exists($this->resource) && @filemtime($this->resource) <= $timestamp; | ||
| $filemtime = @filemtime($this->resource); | ||
|
|
||
| return $filemtime && $filemtime <= $timestamp; |
There was a problem hiding this comment.
These changes can probably be fixed in a lower branch.
There was a problem hiding this comment.
You can probably inline the definition as well, i.e.
return false !== ($filemtime = @filemtime($this->resource)) && $filemtime <= $timestamp;| @@ -34,12 +34,13 @@ public function __construct($class, $path, array $autowiringMetadata) | |||
|
|
|||
| public function isFresh($timestamp) | |||
| { | |||
| if (!file_exists($this->filePath)) { | |||
| $filemtime = @filemtime($this->filePath); | |||
| if (!$filemtime) { | |||
There was a problem hiding this comment.
The changes in this file can probably also be applied on a lower branch.
There was a problem hiding this comment.
same as @sroze you can inline all this condition
| return file_exists($this->resource) && @filemtime($this->resource) <= $timestamp; | ||
| $filemtime = @filemtime($this->resource); | ||
|
|
||
| return $filemtime && $filemtime <= $timestamp; |
There was a problem hiding this comment.
You can probably inline the definition as well, i.e.
return false !== ($filemtime = @filemtime($this->resource)) && $filemtime <= $timestamp;| @@ -37,11 +37,12 @@ public function isFresh($timestamp) | |||
| } | |||
|
|
|||
| foreach ($this->files as $file => $v) { | |||
| if (!file_exists($file)) { | |||
| $filemtime = @filemtime($file); | |||
| if (!$filemtime) { | |||
There was a problem hiding this comment.
inline?
if (false === ($filemtime = @filemtime($file))) {|
Also, it would be good to give the pull-request a nice title, such as "Only using |
|
Travis failure seems unrelated to the changes |
Uh oh!
There was an error while loading. Please reload this page.