[DI] Fix tracking of source class changes for lazy-proxies #25981
Conversation
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -398,6 +398,7 @@ private function generateProxyClasses() | |||
| if (!$proxyDumper->isProxyCandidate($definition)) { | |||
| continue; | |||
| } | |||
| $this->container->getReflectionResource($definition->getClass()); | |||
There was a problem hiding this comment.
Where does this method come from and what is it doing? 🤔
There was a problem hiding this comment.
From the moon of course! comment added :)
There was a problem hiding this comment.
That's weird, I can't find its definition anywhere. Maybe only on GitHub's moon version? 😄
Though, registering something by calling a getter is weirdo.
There was a problem hiding this comment.
oups, bad method name :) fixed
There was a problem hiding this comment.
Aaaah, makes much more sense!
1e85db0 to
aede64a
Compare
aede64a to
4f18e4b
Compare
| @@ -842,7 +842,7 @@ protected function dumpContainer(ConfigCache $cache, ContainerBuilder $container | |||
| $dumper = new PhpDumper($container); | |||
|
|
|||
| if (class_exists('ProxyManager\Configuration') && class_exists('Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper')) { | |||
| $dumper->setProxyDumper(new ProxyDumper(substr(hash('sha256', $cache->getPath()), 0, 7))); | |||
There was a problem hiding this comment.
this doesn't serve any purpose now, and made container's cache path-dependend
There was a problem hiding this comment.
should we deprecate the salt argument in 4.1 ?
There was a problem hiding this comment.
that's possible, although it doesn't really hurt, so low priority on my side (if anyone wants to do it, PR welcome :))
|
Thank you @nicolas-grekas. |
… (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix tracking of source class changes for lazy-proxies | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 4f18e4b [DI] Fix tracking of source class changes for lazy-proxies