8000 [Routing] Make sure we only build routes once by sroze · Pull Request #25791 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Make sure we only build routes once #25791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2018
Merged

[Routing] Make sure we only build routes once #25791

merged 1 commit into from
Jan 16, 2018

Conversation

sroze
Copy link
Contributor
@sroze sroze commented Jan 15, 2018 •
edited
Loading
Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25746
License MIT
Doc PR ø

We need to build the collection(s) only once, else the prefix would be duplicated.

@sroze sroze changed the title Make sure we only build once and have one time the prefix when import… [Routing] Make sure we only build routes once Jan 15, 2018
@sroze sroze changed the base branch from master to 3.3 January 15, 2018 10:34
@sroze
Copy link
Contributor Author
sroze commented Jan 15, 2018 •
edited
Loading

I've pressed [enter] to quick... can some of you remove the "Deprecation" and "BC Break" labels please? Also, fabbot's review is false-positive.

@sroze sroze force-pushed the bugfix/single-prefix-for-multiple-route-collections branch from 832c530 to 927a75a Compare January 15, 2018 10:37
@sroze sroze mentioned this pull request Jan 15, 2018
Closed
@sroze
Copy link
Contributor Author
sroze commented Jan 15, 2018

Thanks @javiereguiluz. The failure is HHVM and is not related.

@fabpot
Copy link
Member
fabpot commented Jan 16, 2018

Thank you @sroze.

@fabpot fabpot merged commit 927a75a into symfony:3.3 Jan 16, 2018
fabpot added a commit that referenced this pull request Jan 16, 2018
@fabpot
bug #25791 [Routing] Make sure we only build routes once (sroze)
663f3f0 
This PR was merged into the 3.3 branch.

Discussion
----------

[Routing] Make sure we only build routes once

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25746
| License       | MIT
| Doc PR        | ø

We need to build the collection(s) only once, else the prefix would be duplicated.

Commits
-------

927a75a Make sure we only build once and have one time the prefix when importing routes
This was referenced Jan 29, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Routing Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sroze @fabpot @xabbuh @javiereguiluz @carsonbot
0