8000 [WebProfilerBundle] set the var in the right scope by frag-seb · Pull Request #25678 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] set the var in the right scope #25678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WebProfilerBundle] set the var in the right scope #25678

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc572e7
fix: set the var in the right scope
Jan 4, 2018
fb63032
fix: New var in the panel block.
Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
} %}
{% endif %}

{% set has_time_events = collector.events|length > 0 %}

{% block toolbar %}
{% set has_time_events = collector.events|length > 0 %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be duplicated in {% block panel %} too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's right!


{% set total_time = has_time_events ? '%.0f'|format(collector.duration) : 'n/a' %}
{% set initialization_time = collector.events|length ? '%.0f'|format(collector.inittime) : 'n/a' %}
{% set status_color = has_time_events and collector.duration > 1000 ? 'yellow' : '' %}
Expand Down Expand Up @@ -49,6 +50,7 @@
{% endblock %}

{% block panel %}
{% set has_time_events = collector.events|length > 0 %}
<h2>Performance metrics</h2>

<div class="metrics">
Expand Down
0