Fix bug #25665: Type of column for timestamp changed to signed #25667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this will not fix the issue for people that already have created the table |
c5c2827 to
47bd987
Compare
|
ping @WhiteEagle88 ? Status: needs work |
| @@ -375,7 +375,7 @@ public function close() | |||
| $this->gcCalled = false; | |||
|
|
|||
| // delete the session records that have expired | |||
| $sql = "DELETE FROM $this->table WHERE $this->lifetimeCol < :time - $this->timeCol"; | |||
| $sql = "DELETE FROM $this->table WHERE $this->lifetimeCol < :time - CAST($this->timeCol AS SIGNED)"; | |||
There was a problem hiding this comment.
would it make sense to just change this to $this->lifetimeCol + $this->timeCol < :time? (thus revert the change on the "create table")
|
Closing in favor of #25922, thanks for proposing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PDO session timestamp out of range for MySQL