[Security] Fix fatal error on non string username #25657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9da049f to
6894e56
Compare
|
I think we should do the same with the provided password. |
| $password = $requestBag->get($this->options['password_parameter'], null, true); | ||
|
|
||
| if (!is_string($username)) { | ||
| throw new BadRequestHttpException(sprintf('The key "%s" must be a string.', $this->options['username_parameter'])); |
There was a problem hiding this comment.
This kind of messages in Symfony are usually like:
sprintf('The XXX must be a string, "%s" given.', gettype($XXX))Is it necessary to do the same here?
Simperfit
reviewed
Jan 5, 2018
| $password = $requestBag->get($this->options['password_parameter'], null, true); | ||
|
|
||
| if (!is_string($username)) { | ||
| throw new BadRequestHttpException(sprintf('The key "%s" must be a string.', $this->options['username_parameter'])); |
There was a problem hiding this comment.
as javiere said I think we should change both message too.
6894e56 to
4205e5e
Compare
4205e5e to
a3e17da
Compare
|
@chalasr tests are failing |
|
@xabbuh done. Objects implementing |
a3e17da to
15ecf24
Compare
|
@chalasr I also wonder if not passing credentials at all must be supported here. |
e9e6818 to
d7e615f
Compare
|
Thanks for the patch! I was going to submit the same issue ;) |
|
@xabbuh I think so, password part reverted and |
xabbuh
reviewed
Jan 12, 2018
| array('require_previous_session' => false) | ||
| ); | ||
|
|
||
| $event = $this->getMockBuilder('Symfony\Component\HttpKernel\Event\GetResponseEvent')->disableOriginalConstructor()->getMock(); |
d7e615f to
8f09568
Compare
|
Ready |
xabbuh
approved these changes
Jan 15, 2018
Simperfit
approved these changes
Jan 15, 2018
fabpot
approved these changes
Jan 16, 2018
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jan 16, 2018
This PR was merged into the 2.7 branch. Discussion ---------- [Security] Fix fatal error on non string username | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25612 | License | MIT | Doc PR | n/a That's consistent with what #22569 did for the `json_login` listener. Commits ------- 8f09568 [Security] Fix fatal error on non string username
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's consistent with what #22569 did for the
json_loginlistener.