Backport Flex-specific error messages in controller shortcuts to 3.4 #25636
Conversation
|
👍 , but why not 3.4? |
| @@ -153,7 +153,7 @@ protected function file($file, string $fileName = null, string $disposition = Re | |||
| protected function addFlash(string $type, string $message) | |||
| { | |||
| if (!$this->container->has('session')) { | |||
| throw new \LogicException('You can not use the addFlash method if sessions are disabled.'); | |||
| throw new \LogicException('You can not use the addFlash method if sessions are disabled. Enable them in config/packages/framework.yaml.'); | |||
There was a problem hiding this comment.
This is not consistent with other message (no quotes but dot at the end).
38d12ea to
4f7dee7
Compare
no objection for me, 4.0 was the target of #25133. |
|
As a general rule of thumb, almost all PRs that target 4.0 should really target 3.4: both versions share the same bugs (with rare exceptions.) |
|
rebased |
|
Note that symfony-standard exists in 3.4, these suggestions would be wrong there. |
| @@ -194,7 +194,7 @@ protected function file($file, $fileName = null, $disposition = ResponseHeaderBa | |||
| protected function addFlash($type, $message) | |||
| { | |||
| if (!$this->container->has('session')) { | |||
| throw new \LogicException('You can not use the addFlash method if sessions are disabled.'); | |||
| throw new \LogicException('You can not use the addFlash method if sessions are disabled. Enable them in "config/packages/framework.yaml"'); | |||
There was a problem hiding this comment.
Error messages like this -> Enable them in "config/packages/framework.yaml" could be problematic for 3.4 app ... which probably use the same dir layout that 3.3. The new layout is only generally used in 4.0 and newer.
There was a problem hiding this comment.
Most of the exceptions will probably never be shown if you depend on the Standard Edition (this one is indeed a bit different, but we could additionally check for the FullStack class).
|
Thank you @chalasr. |
…tcuts to 3.4 (weaverryan) This PR was merged into the 3.4 branch. Discussion ---------- Backport Flex-specific error messages in controller shortcuts to 3.4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25133 (comment) | License | MIT | Doc PR | n/a Commits ------- 419e934 Proposing Flex-specific error messages in the controller shortcuts
Uh oh!
There was an error while loading. Please reload this page.