[Console] Simplify parameters in DI #25593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8152efa to
ae47805
Compare
nicolas-grekas
approved these changes
Dec 24, 2017
|
Can we remove this check https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Console/Application.php#L166 or is it needed for 3-4 compatibility? |
|
It's needed as long as framework bundle supports 3.4 console. |
chalasr
approved these changes
Dec 25, 2017
|
Thank you @Tobion. |
chalasr
pushed a commit
that referenced
this pull request
Dec 25, 2017
This PR was merged into the 4.0 branch.
Discussion
----------
[Console] Simplify parameters in DI
| Q | A
| ------------- | ---
| Branch? | 4.0
| Bug fix? | no
| New feature? |no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks? | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Currently the container gets filled with alot of ugly params like
```
'console.command.ids' => array(
'console.command.symfony_bundle_frameworkbundle_command_aboutcommand' => 'console.command.about',
'console.command.symfony_bundle_frameworkbundle_command_assetsinstallcommand' => 'console.command.assets_install',
'console.command.symfony_bundle_frameworkbundle_command_cacheclearcommand' => 'console.command.cache_clear',
...
),
'console.lazy_command.ids' => array(
'console.command.about' => true,
'console.command.assets_install' => true,
'console.command.cache_clear' => true,
...
```
We can get rid of these in 4.0 with a little refactoring.
- SF 4.0 does not include the auto-registration of commands anymore which was the reason why the `console.command.ids` used the class name as index to prevent commands already defined as service to not triggger auto-registration. -> The param does not need the index lookup anymore in 4.0
- What I now also changed is that this param only contains the command IDs of services that are NOT lazy loaded. This way, we don't need `console.lazy_command.ids` at all. This is a simplification of #24073 and still ensures framework bundle console application is compatible with console component 3.x and 4.x
Commits
-------
ae47805 [Console] Simplify parameters in DI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the container gets filled with alot of ugly params like
We can get rid of these in 4.0 with a little refactoring.
console.command.idsused the class name as index to prevent commands already defined as service to not triggger auto-registration. -> The param does not need the index lookup anymore in 4.0console.lazy_command.idsat all. This is a simplification of [Console] Fix BC break in console.command.ids parameter #24073 and still ensures framework bundle console application is compatible with console component 3.x and 4.x