[Console] Fixed BC bug when mixing short & long options #25574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you post a reproducer ? because https://github.com/symfony/symfony/pull/25487/files#diff-3ae4ec9ae7b044c86a061156979d87fbR287 does fix this behaviour. if you remove the explode then it shows the shell, with the explode it does not. So I think this check is useless. |
Simperfit
reviewed
Dec 21, 2017
|
|
||
| if (0 === strpos($token, '-') && 0 !== strpos($token, '--')) { | ||
| $noValue = explode('=', $token); | ||
| $token = $noValue[0]; |
Contributor
Author
|
@Simperfit Right, looks like this is duplicate then. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #25487 introduced BC break when call to command was mixing both, short & long options.
v2.7.38(notice-e=testat end):v2.7.39:$ app/console cache:warmup --no-ansi --no-interaction --no-debug -e=test _____ __ / ____| / _| | (___ _ _ _ __ ___ | |_ ___ _ __ _ _ \___ \| | | | '_ ` _ \| _/ _ \| '_ \| | | | ____) | |_| | | | | | | || (_) | | | | |_| | |_____/ \__, |_| |_| |_|_| \___/|_| |_|\__, | __/ | __/ | |___/ |___/ Welcome to the Symfony shell (2.8.32 - app/test). At the prompt, type h 10000 elp for some help, or list to get a list of available commands. To exit the shell, type ^D. Symfony >