8000 [Console] Fixed BC bug when mixing short & long options by stloyd · Pull Request #25574 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Fixed BC bug when mixing short & long options #25574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Console] Fixed BC bug when mixing short & long options #25574

wants to merge 1 commit into from

Conversation

stloyd
Copy link
Contributor
@stloyd stloyd commented Dec 21, 2017
Q A
Branch? 2.7+
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

PR #25487 introduced BC break when call to command was mixing both, short & long options.

v2.7.38 (notice -e=test at end):

$ app/console cache:warmup --no-ansi --no-interaction --no-debug -e=test
 // Warming up the cache for the test environment with debug false

 [OK] Cache for the "test" environment (debug=false) was successfully warmed.

v2.7.39:

$ app/console cache:warmup --no-ansi --no-interaction --no-debug -e=test

      _____                  __
     / ____|                / _|
    | (___  _   _ _ __ ___ | |_ ___  _ __  _   _
     \___ \| | | | '_ ` _ \|  _/ _ \| '_ \| | | |
     ____) | |_| | | | | | | || (_) | | | | |_| |
    |_____/ \__, |_| |_| |_|_| \___/|_| |_|\__, |
             __/ |                          __/ |
            |___/                          |___/


Welcome to the Symfony shell (2.8.32 - app/test).

At the prompt, type help for some help,
or list to get a list of available commands.

To exit the shell, type ^D.

Symfony >

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Dec 21, 2017
@Simperfit
Copy link
Contributor
Simperfit commented Dec 21, 2017 •
edited
Loading

Can you post a reproducer ? because https://github.com/symfony/symfony/pull/25487/files#diff-3ae4ec9ae7b044c86a061156979d87fbR287 does fix this behaviour.

if you remove the explode then it shows the shell, with the explode it does not.

So I think this check is useless.

Simperfit
Simperfit reviewed Dec 21, 2017
View reviewed changes
src/Symfony/Component/Console/Input/ArgvInput.php
@@ -288,7 +288,7 @@ public function hasParameterOption($values)
$token = $noValue[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does it already.

@stloyd
Copy link
Contributor Author
stloyd commented Dec 21, 2017

@Simperfit Right, looks like this is duplicate then. Closing.

@stloyd stloyd closed this Dec 21, 2017
@stloyd stloyd deleted the patch-6 branch December 21, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simperfit Simperfit Simperfit left review comments

Assignees
No one assigned
Labels
Bug Console Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@stloyd @Simperfit @nicolas-grekas @carsonbot
0