8000 [2.7] Fix issues found by PHPStan by nicolas-grekas · Pull Request #25558 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.7] Fix issues found by PHPStan #25558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2017
Merged

[2.7] Fix issues found by PHPStan #25558

merged 1 commit into from
Dec 20, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This is the subpart of #25536 that applies on 2.7.
ping @dkarlovi FYI.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Dec 20, 2017
ro0NL
ro0NL reviewed Dec 20, 2017
View reviewed changes
src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php Outdated
@@ -1103,8 +1102,7 @@ public function testLoaderCaching()
$repo = $this->em->getRepository(self::SINGLE_IDENT_CLASS);

$entityType = new EntityType(
$this->emRegistry,
PropertyAccess::createPropertyAccessor()
$this->emRegistry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, fixed

javiereguiluz
javiereguiluz approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes. Wrong namespaces and wrong spelling of PHP functions is always hard to detect. Thanks!

@nicolas-grekas
Copy link
Member Author

Thank you @dkarlovi.

@nicolas-grekas nicolas-grekas merged commit afa1f14 into symfony:2.7 Dec 20, 2017
nicolas-grekas added a commit that referenced this pull request Dec 20, 2017
@nicolas-grekas
minor #25558 [2.7] Fix issues found by PHPStan (dkarlovi)
f99eb65 
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Fix issues found by PHPStan

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is the subpart of #25536 that applies on 2.7.
ping @dkarlovi FYI.

Commits
-------

afa1f14 [2.7] Fix issues found by PHPStan
@nicolas-grekas nicolas-grekas deleted the phpstan27 branch December 20, 2017 09:59
@nicolas-grekas
Copy link
Member Author

Now merged up to master.

@dkarlovi
Copy link
Contributor

Nice. 👍

@dkarlovi dkarlovi mentioned this pull request Sep 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@ro0NL ro0NL ro0NL approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @dkarlovi @javiereguiluz @ro0NL @carsonbot
0