10000 Lock ternary_to_null_coalescing in PHPCS by carusogabriel · Pull Request #25551 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Lock ternary_to_null_coalescing in PHPCS #25551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Lock ternary_to_null_coalescing in PHPCS #25551

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor
@carusogabriel carusogabriel commented Dec 19, 2017 •
edited by nicolas-grekas
Loading
Q A
Branch? 2.7 (be careful when merging)
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25416
License MIT
Doc PR -

To avoid other developers PR like #25416 😅

@nicolas-grekas
Copy link
Member

👍 for 2.7

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Dec 19, 2017
@carusogabriel
Copy link
Contributor Author

@nicolas-grekas Gonna change it!

@carusogabriel carusogabriel changed the base branch from master to 2.7 December 19, 2017 12:48
@keradus
Copy link
Member
keradus commented Dec 19, 2017

this rule is not part of current ruleset, thus there is no need to disable it.
if you want to explicitly disable it to say to other devs it cannot be enabled, then make comment explaining that.

@keradus
Copy link
Member
keradus commented Dec 19, 2017

(btw, PHPCS is different tool than you are touching here)

@nicolas-grekas
Copy link
Member

Closing in favor of #25556

@nicolas-grekas nicolas-grekas mentioned this pull request Dec 20, 2017
Closed
@carusogabriel carusogabriel deleted the patch-1 branch December 20, 2017 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@carusogabriel @nicolas-grekas @keradus @carsonbot
0