10000 WIP [Meta] Add PHPStan to build process by dkarlovi · Pull Request #25536 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

WIP [Meta] Add PHPStan to build process #25536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

WIP [Meta] Add PHPStan to build process #25536

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e1be251
[Meta] add PHPStan via jakzal/phpqa
dkarlovi Dec 18, 2017
bfb3048
[Meta] fix issues found via PHPStan in Bridge
dkarlovi Dec 18, 2017
9183062
[Meta] fix issues found via PHPStan in Bundle
dkarlovi Dec 18, 2017
d9e30ae
[Meta] fix issues found via PHPStan in Config component
dkarlovi Dec 18, 2017
83c1208
[Meta] fix issues found via PHPStan in Debug component
dkarlovi Dec 18, 2017
bdeda31
[Meta] fix issues found via PHPStan in DI component
dkarlovi Dec 18, 2017
0a33eb1
[Meta] fix issues found via PHPStan in Filesystem component
dkarlovi Dec 18, 2017
a7dff25
[Meta] fix issues found via PHPStan in Debug component
dkarlovi Dec 18, 2017
03daa41
[Meta] fix issues found via PHPStan in HttpFoundation component
dkarlovi Dec 18, 2017
da9d0e4
[Meta] fix issues found via PHPStan in Workflow component
dkarlovi Dec 18, 2017
75403df
[Meta] PHPStan, switch to a custom Docker image with all required exts
dkarlovi Dec 18, 2017
c5467e0
[Meta] PHPStan, move autoloaded files from Composer to PHPStan
dkarlovi Dec 19, 2017
dbdf9de
[Meta] PHPS 10000 tan, undo changes to Debug component
dkarlovi Dec 19, 2017
5fc8d8e
[Meta] PHPStan, undo changes to DependencyInjection component
dkarlovi Dec 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Meta] fix issues found via PHPStan in HttpFoundation component
  • Loading branch information
@dkarlovi
dkarlovi committed Dec 18, 2017
commit 03daa419c6ee340543abacc4b644df9069d0fba2
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpFoundation/Tests/ResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ public function ianaCodesReasonPhrasesProvider()

$ianaCodesReasonPhrases = array();

$xpath = new \DomXPath($ianaHttpStatusCodes);
$xpath = new \DOMXPath($ianaHttpStatusCodes);
$xpath->registerNamespace('ns', 'http://www.iana.org/assignments');

$records = $xpath->query('//ns:record');
Expand Down
4 changes: 2 additions & 2 deletions ...mfony/Component/HttpFoundation/Tests/Session/Storage/Handler/StrictSessionHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ public function testOpen()
->with('path', 'name')->willReturn(true);
$proxy = new StrictSessionHandler($handler);

$this->assertInstanceof('SessionUpdateTimestampHandlerInterface', $proxy);
$this->assertInstanceof(AbstractSessionHandler::class, $proxy);
$this->assertInstanceOf('SessionUpdateTimestampHandlerInterface', $proxy);
$this->assertInstanceOf(AbstractSessionHandler::class, $proxy);
$this->assertTrue($proxy->open('path', 'name'));
}

Expand Down
0