10000 [HttpKernel][DX] Allow the log level of http exceptions to be overridden by mtibben · Pull Request #25533 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel][DX] Allow the log level of http exceptions to be overridden #25533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

[HttpKernel][DX] Allow the log level of http exceptions to be overridden #25533

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
01c51e2
Allow the log level to be overriden based on the http status code
mtibben Dec 17, 2017
8a77728
Make httpStatusCodeLogLevel a class property
mtibben Dec 18, 2017
5ef1878
Separate log level logic to its own method
mtibben Dec 18, 2017
06bb76a
Fix code style
mtibben Dec 18, 2017
367e68e
Add param for setting log levels in DI
mtibben Dec 19, 2017
2288c5b
Fixes from PR feedback
mtibben Dec 27, 2017
c1d0dea
Log http 4xx as warning
mtibben Dec 27, 2017
dc246e0
Add tests for log level overrides
mtibben Dec 27, 2017
25fd9e4
Add to twig bundle configuration
mtibben Dec 27, 2017 8000
d0948d7
De-yoda conditionals
mtibben Dec 27, 2017
15b15a5
Split into two listeners
mtibben Jan 5, 2018
9236f62
Revert "[HttpKernel] Decouple exception logging from rendering"
mtibben Jan 5, 2018
1f08bc0
Restore ExceptionListener as exception rendering listener, add BC mode
mtibben Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
De-yoda conditionals
  • Loading branch information
@mtibben
mtibben committed Jan 19, 2018
commit d0948d72d21e0208072e39275deca2de39d179a5
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ private function addHttpExceptionLogLevels(ArrayNodeDefinition $rootNode)
->always(function ($v) {
$map = array();
foreach ($v as $status => $level) {
if (!(is_int($status) && 100 <= $status && $status <= 599)) {
if (!(is_int($status) && $status >= 100 && $status <= 599)) {
throw new InvalidConfigurationException(sprintf(
'The configured status code "%s" in twig.http_exception_log_levels is not a valid http status code.',
$status
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ protected function getExceptionLogLevel(\Exception $exception): string
$statusCode = $exception->getStatusCode();
if (isset($this->httpStatusCodeLogLevel[$statusCode])) {
$logLevel = $this->httpStatusCodeLogLevel[$statusCode];
} elseif (400 <= $statusCode && $statusCode < 500) {
} elseif ($statusCode >= 400 && $statusCode < 500) {
$logLevel = LogLevel::WARNING;
}
}
Expand Down
0