Add ControllerTrait::getParameter() #25439
Conversation
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25288 (comment) |
| License | MIT |
| Doc PR | n/a |
96d41b7 to
54f063e
Compare
| return; | ||
| } | ||
|
|
||
| if (method_exists($this, 'expectException')) { |
There was a problem hiding this comment.
You can remove this check for new code. As Symfony 4 requires PHP 7.1+, it will not need to run tests on PHPUnit 4.8 (which is needed for PHP 5.5 and older). So expectException can always be used.
There was a problem hiding this comment.
thanks, we have a bunch of similar checks to remove https://github.com/symfony/symfony/search?utf8=%E2%9C%93&q=setExpectedException&type=
54f063e to
799bc10
Compare
8d047c9 to
2262186
Compare
|
should we add an |
|
@nicolas-grekas |
| * | ||
| * @return mixed | ||
| * | ||
| * @final since version 4.1 |
There was a problem hiding this comment.
just @final (since always - it didn't exist before)
2262186 to
28397e5
Compare
|
Thank you @chalasr. |
This PR was merged into the 4.1-dev branch. Discussion ---------- Add ControllerTrait::getParameter() | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25288 (comment) | License | MIT | Doc PR | n/a Commits ------- 28397e5 Add ControllerTrait::getParameter()
|
I just tried using this because of today's blog post and it seems quite fundamentally broken? The |
|
Oh it got screwed over later at 3051289#diff-ef10778bc68793f8c8f4b71a7ba67790R86 while refactoring, @nicolas-grekas missed 3 characters in typing it hehe. |
… (curry68 854D 4) This PR was submitted for the master branch but it was squashed and merged into the 4.1 branch instead (closes #27415). Discussion ---------- Insert correct parameter_bag service in AbstractController Reverts this feature being broken in 3051289#diff-ef10778bc68793f8c8f4b71a7ba67790R86 - `getParameter` could never work now as it was querying the container itself instead of the parameter bag. | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | License | MIT Also see comments at #25439 (comment) Commits ------- 37270d7 Insert correct parameter_bag service in AbstractController