grammar typo in docs #25421
Merged
grammar typo in docs #25421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | master for features / 2.7 up to 4.0 for bug fixes |
| Bug fix? | yes/no |
| New feature? | yes/no |
| BC breaks? | yes/no |
| Deprecations? | yes/no |
| Tests pass? | yes/no |
| Fixed tickets | #... |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
xabbuh
approved these changes
Dec 10, 2017
chalasr
approved these changes
Dec 10, 2017
Simperfit
approved these changes
Dec 11, 2017
|
Good catch, thanks @michaelKaefer. |
chalasr
added a commit
that referenced
this pull request
Dec 11, 2017
This PR was merged into the 4.1-dev branch. Discussion ---------- grammar typo in docs | Q | A | ------------- | --- | Branch? | master for features / 2.7 up to 4.0 for bug fixes <!-- see below --> | Bug fix? | yes/no | New feature? | yes/no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | yes/no | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes/no | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Replace this comment by a description of what your PR is solving. --> Commits ------- d53c889 grammar typo in docs
chalasr
added a commit
that referenced
this pull request
Dec 11, 2017
This PR was merged into the 4.1-dev branch. Discussion ---------- grammar typo in docs | Q | A | ------------- | --- | Branch? | master for features / 2.7 up to 4.0 for bug fixes <!-- see below --> | Bug fix? | yes/no | New feature? | yes/no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | yes/no | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes/no | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Replace this comment by a description of what your PR is solving. --> Commits ------- d53c889 grammar typo in docs
|
Backported on 3.4 in d21aa19 |
chalasr
added a commit
that referenced
this pull request
Dec 11, 2017
* 3.4: minor #25421 grammar typo in docs (michaelKaefer) Extend Argon2i support check to account for sodium_compat
chalasr
added a commit
that referenced
this pull request
Dec 11, 2017
* 4.0: minor #25421 grammar typo in docs (michaelKaefer) Extend Argon2i support check to account for sodium_compat
fabpot
added a commit
that referenced
this pull request
Dec 11, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Fix incorrect phpdoc | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Bad copy-pastes, spotted in #25421 Commits ------- 8be950f [Lock] Fix incorrect phpdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.