8000 [HttpKernel] Fix logging of post-terminate errors/exceptions by nicolas-grekas · Pull Request #25410 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Fix logging of post-terminate errors/exceptions #25410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2017
Merged

[HttpKernel] Fix logging of post-terminate errors/exceptions #25410

merged 1 commit into from
Dec 11, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19078
License MIT
Doc PR -

After terminate, the request stack is empty, thus terminateWithException currently fails, preventing listeners to know about the failure.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Dec 9, 2017
@nicolas-grekas nicolas-grekas force-pushed the kernel-excepton branch 2 times, most recently from 6e48ec9 to a7d00b6 Compare December 9, 2017 19:43
@fabpot
Copy link
Member
fabpot commented Dec 11, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit e85b371 into symfony:2.7 Dec 11, 2017
fabpot added a commit that referenced this pull request Dec 11, 2017
@fabpot
bug #25410 [HttpKernel] Fix logging of post-terminate errors/exceptio…
b78c0ae 
…ns (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[HttpKernel] Fix logging of post-terminate errors/exceptions

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19078
| License       | MIT
| Doc PR        | -

After terminate, the request stack is empty, thus `terminateWithException` currently fails, preventing listeners to know about the failure.

Commits
-------

e85b371 [HttpKernel] Fix logging of post-terminate errors/exceptions
@nicolas-grekas nicolas-grekas deleted the kernel-excepton branch December 11, 2017 20:55
This was referenced Dec 15, 2017
Merged
Merged
This was referenced Jan 5, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @Simperfit @carsonbot
0