[HttpKernel] Fix logging of post-terminate errors/exceptions #25410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
approved these changes
Dec 9, 2017
6e48ec9 to
a7d00b6
Compare
a7d00b6 to
e85b371
Compare
fabpot
approved these changes
Dec 11, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2017
…ns (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] Fix logging of post-terminate errors/exceptions | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19078 | License | MIT | Doc PR | - After terminate, the request stack is empty, thus `terminateWithException` currently fails, preventing listeners to know about the failure. Commits ------- e85b371 [HttpKernel] Fix logging of post-terminate errors/exceptions
This was referenced Jan 5, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After terminate, the request stack is empty, thus
terminateWithExceptioncurrently fails, preventing listeners to know about the failure.