8000 Remove some unused variables and properties by tgalopin · Pull Request #25402 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Remove some unused variables and properties #25402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ public function filterToServiceTypes($serviceId)
}

try {
$r = new \ReflectionClass($serviceId);
new \ReflectionClass($serviceId);

return true;
} catch (\ReflectionException $e) {
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class TagAwareAdapter implements TagAwareAdapterInterface, PruneableInterface, R
private $setCacheItemTags;
private $getTagsByKey;
private $invalidateTags;
private $tagsPool;
private $tags;

public function __construct(AdapterInterface $itemsPool, AdapterInterface $tagsPool = null)
{
Expand Down
6 changes: 0 additions & 6 deletions src/Symfony/Component/Lock/Store/MemcachedStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@
*/
class MemcachedStore implements StoreInterface
{
private static $defaultClientOptions = array(
'persistent_id' => null,
'username' => null,
'password' => null,
);

private $memcached;
private $initialTtl;
/** @var bool */
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/Yaml/Parser.php
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,6 @@ private function doParse($value, $flags)
@trigger_error($this->getDeprecationMessage(sprintf('Duplicate key "%s" detected whilst parsing YAML. Silent handling of duplicate mapping keys in YAML is deprecated since version 3.2 and will throw \Symfony\Component\Yaml\Exception\ParseException in 4.0.', $key)), E_USER_DEPRECATED);
}
} else {
// remember the parsed line number here in case we need it to provide some contexts in error messages below
$realCurrentLineNbKey = $this->getRealCurrentLineNb();
$value = $this->parseBlock($this->getRealCurrentLineNb() + 1, $this->getNextEmbedBlock(), $flags);
if ('<<' === $key) {
$this->refs[$refMatches['ref']] = $value;
Expand Down
0