8000 [Process] add type hint and changelog entry by xabbuh · Pull Request #25388 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Process] add type hint and changelog entry #25388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2017
Merged

[Process] add type hint and changelog entry #25388

merged 1 commit into from
Dec 9, 2017

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Dec 8, 2017
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.1 milestone Dec 8, 2017
nicolas-grekas
nicolas-grekas reviewed Dec 8, 2017
View reviewed changes
src/Symfony/Component/Process/Process.php
*/
public static function isTtySupported()
public static function isTtySupported(): bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bc break, isn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, new 4.1 function!

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 5a1dc67 into symfony:master Dec 9, 2017
nicolas-grekas added a commit that referenced this pull request Dec 9, 2017
@nicolas-grekas
minor #25388 [Process] add type hint and changelog entry (xabbuh)
7b55449 
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Process] add type hint and changelog entry

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

5a1dc67 add type hint and changelog entry
@xabbuh xabbuh deleted the pr-25142 branch December 9, 2017 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Process Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @Simperfit @carsonbot
0