8000 [Serializer] split off an EncoderInterface and NormalizerInterface from SerializerInte by lsmith77 · Pull Request #2530 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] split off an EncoderInterface and NormalizerInterface from SerializerInte #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 14, 2011
Merged

[Serializer] split off an EncoderInterface and NormalizerInterface from SerializerInte #2530

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b0daf35
split off an EncoderInterface and NormalizerInterface from Serializer…
lsmith77 Nov 1, 2011
58bd0f5
refactored the EncoderInterface
lsmith77 Nov 8, 2011
f8e2787
refactored Normalizer interfaces
lsmith77 Nov 8, 2011
d021dc8
refactored encoder handling to use the supports*() methods to determi…
lsmith77 Nov 8, 2011
2a6741c
typo fix
lsmith77 Nov 8, 2011
c3a711d
abstract class children should also implement dernormalization
lsmith77 Nov 8, 2011
078f7f3
more typo fixes
lsmith77 Nov 8, 2011
c3d6123
re-added supports(de)normalization()
lsmith77 Nov 8, 2011
351eaa8
require a (de)normalizer inside the (de)normalizable interfaces inste…
lsmith77 Nov 8, 2011
d811e29
CS fix
lsmith77 Dec 11, 2011
067242d
updated serializer tests to use the new interfaces
lsmith77 Dec 11, 2011
967531f
fixed various typos from the refactoring
lsmith77 Dec 11, 2011
cb495fd
added additional unit tests for deserialization
lsmith77 Dec 11, 2011
97389fa
use Serializer specific RuntimeException
lsmith77 Dec 11, 2011
72b9083
SerializerAwareNormalizer now only implements SerializerAwareInterface
lsmith77 Dec 11, 2011
0776b50
removed supports(De)Serializiation()
lsmith77 Dec 14, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
abstract class children should also implement dernormalization
  • Loading branch information
@lsmith77
lsmith77 committed Dec 11, 2011
commit c3a711d3f21fd4faa4b0ff7bccf27f92cf39ff2b
2 changes: 1 addition & 1 deletion src/Symfony/Component/Serializer/Normalizer/SerializerAwareNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*
* @author Jordi Boggiano <j.boggiano@seld.be>
*/
abstract class SerializerAwareNormalizer implements SerializerAwareInterface, NormalizerInterface
abstract class SerializerAwareNormalizer implements SerializerAwareInterface, NormalizerInterface, DenormalizerInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one should only implement SerializerAwareInterface IMO as it only defines method for this one. This would allow using it for a serializer-aware normalizer which is not a denormalizer (and the opposite)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right .. fixed.

{
protected $serializer;

Expand Down
0