#25187 Lookup php binary in PHP_BINDIR first #25188
Conversation
| @@ -23,6 +23,8 @@ class ExecutableFinder | |||
|
|
|||
| /** | |||
| * Replaces default suffixes of executable. | |||
| * | |||
| * @param array $suffixes | |||
There was a problem hiding this comment.
This can be removed as all the information are already part of the method signature.
|
Since this change is for a bugfix-only branch, I think the patch should be reduced to the strict minimum. |
36fb2b2 to
4e8f028
Compare
4e8f028 to
11ccd92
Compare
| if ('\\' === DIRECTORY_SEPARATOR) { | ||
| $dirs[] = 'C:\xampp\php\\'; | ||
| } | ||
|
|
||
| $name = 'php'; | ||
| foreach (array('', '.exe', '.bat', '.cmd', '.com') as $suffix) { |
There was a problem hiding this comment.
reading this, it feels like this logic belongs to the "executableFinder", isn't it?
There was a problem hiding this comment.
Yes, i had changed the executable finder component first to allow looking for executables ONLY in given direcories (currently it is only able to use the given directories as fallback if the executable is not found in the environment path), but you said that it should be reduced to the strict minimum. So the question is: Where should we out this functionality for the bugfix? In long term it would make sense to extend the executable finder with this functionality.
|
Closing in favor of #26040, thank you @Deltachaos |
Refactored
Symfony\Component\Process\ExecutableFinder. ReusingSymfony\Component\Process\ExecutableFinder::findIninSymfony\Component\Process\PhpExecutableFinder::findto fix #25187.