[Serializer] Do not cache attributes if attributes in context
#25185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98561d4 to
303280d
Compare
lyrixx
reviewed
Nov 28, 2017
| @@ -126,7 +126,7 @@ protected function getAttributes($object, $format = null, array $context) | |||
| return $allowedAttributes; | |||
| } | |||
|
|
|||
| if (isset($this->attributesCache[$class])) { | |||
| if (isset($this->attributesCache[$class]) && !isset($context['attributes'])) { | |||
There was a problem hiding this comment.
If $context['attributes'] is defined, we will fill the $this->attributesCache[$class] array with useless values.
IMHO, the correct patch is:
if (!isset($context['attributes']}
return $this->extractAttributes($object, $format, $context);
}before the cache layer
303280d to
6e87382
Compare
lyrixx
approved these changes
Nov 28, 2017
Simperfit
approved these changes
Nov 28, 2017
fabpot
approved these changes
Nov 29, 2017
|
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Nov 29, 2017
…ntext (sroze) This PR was merged into the 3.3 branch. Discussion ---------- [Serializer] Do not cache attributes if `attributes` in context | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25108 | License | MIT | Doc PR | ø Caching attributes based on the class works only when these attributes are not overwritten. This disables the cache when they are. To me, this `extractAttributes` method should actually be a `AttributeResolver` dependency that can be decorated using different caching strategies I'd say but... that's a much bigger refactoring that needs more reflection with @dunglas. Commits ------- 6e87382 Do not cache cache attributes if `attributes` is in the context
This was referenced Nov 30, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching attributes based on the class works only when these attributes are not overwritten. This disables the cache when they are.
To me, this
extractAttributesmethod should actually be aAttributeResolverdependency that can be decorated using different caching strategies I'd say but... that's a much bigger refactoring that needs more reflection with @dunglas.