-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpFoundation] AutExpireFlashBag should not clear new flashes #25182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpFoundation] AutExpireFlashBag should not clear new flashes #25182
Conversation
Tests? :) |
There are no way to return new, so If I add a test It will be the same as the |
And you've got one now 😉 I believe that it's a real bug. |
ping @Tobion I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 get()
does not clear the new flashes. So all()
should not either.
The current behavior is intended. That's not a bug. A flash is something you can get once and only once, no matter if you get it for the current or the next request. |
@fabpot agreed. The point is: if in your code, you add something before the
"previous" ones are displayed, it should not remove the ones you've just
added.
…On Tue, 28 Nov 2017 at 18:05, Fabien Potencier ***@***.***> wrote:
The current behavior is intended. That's not a bug. A flash is something
you can get once and only once, no matter if you get it for the current or
the next request.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#25182 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxHEeBB1MzEdgrHdnZ7AVXrEwElx2Grks5s7EuFgaJpZM4Qst4B>
.
|
I should have read the code first. The code is weird indeed, as |
Thank you @Simperfit. |
…ashes (Simperfit, sroze) This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] AutExpireFlashBag should not clear new flashes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #9318 | License | MIT | Doc PR | none I feel like very happy ! :) But don't worry I'm.  Commits ------- 706201e Test that it do not remove the new flashes when displaying the existing ones 7fe3fe8 [HttpFoundation] AutExpireFlashBag should not clear new flashes
Thanks to @sroze too !
Le mer. 29 nov. 2017 à 02:56, Fabien Potencier <notifications@github.com> a
écrit :
… Merged #25182 <#25182>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25182 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADSq8kCMMsH2sGWgNz_DdCOqmX962eb0ks5s7LnggaJpZM4Qst4B>
.
|
I feel like very happy ! :)
But don't worry I'm.