[HttpFoundation] AutExpireFlashBag should not clear new flashes #25182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests? :) |
|
There are no way to return new, so If I add a test It will be the same as the |
|
And you've got one now 😉 I believe that it's a real bug. |
nicolas-grekas
approved these changes
Nov 28, 2017
|
ping @Tobion I guess |
Tobion
approved these changes
Nov 28, 2017
|
The current behavior is intended. That's not a bug. A flash is something you can get once and only once, no matter if you get it for the current or the next request. |
|
@fabpot agreed. The point is: if in your code, you add something before the
"previous" ones are displayed, it should not remove the ones you've just
added.
…On Tue, 28 Nov 2017 at 18:05, Fabien Potencier ***@***.***> wrote:
The current behavior is intended. That's not a bug. A flash is something
you can get once and only once, no matter if you get it for the current or
the next request.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#25182 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxHEeBB1MzEdgrHdnZ7AVXrEwElx2Grks5s7EuFgaJpZM4Qst4B>
.
|
|
I should have read the code first. The code is weird indeed, as |
fabpot
approved these changes
Nov 29, 2017
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Nov 29, 2017
…ashes (Simperfit, sroze) This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] AutExpireFlashBag should not clear new flashes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #9318 | License | MIT | Doc PR | none I feel like very happy ! :) But don't worry I'm.  Commits ------- 706201e Test that it do not remove the new flashes when displaying the existing ones 7fe3fe8 [HttpFoundation] AutExpireFlashBag should not clear new flashes
|
Thanks to @sroze too !
Le mer. 29 nov. 2017 à 02:56, Fabien Potencier <notifications@github.com> a
écrit :
… Merged #25182 <#25182>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25182 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADSq8kCMMsH2sGWgNz_DdCOqmX962eb0ks5s7LnggaJpZM4Qst4B>
.
|
This was referenced Nov 30, 2017
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like very happy ! :)
But don't worry I'm.