[DI] Fix tracking of env vars in exceptions #25163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f003f9 to
a662881
Compare
a662881 to
73f1ac5
Compare
SCIF
reviewed
Nov 26, 2017
| $tmpContainer = new ContainerBuilder($resolvingBag); | ||
| $tmpContainer->setResourceTracking($container->isTrackingResources()); | ||
| $tmpContainer->addObjectResource($extension); | ||
| if ($extension instanceof ConfigurationExtensionInterface && null !== $configuration = $extension->getConfiguration($config, $tmpContainer)) { |
There was a problem hiding this comment.
Indeed :) Was here before, and not forbidden by our policy, you can find many others in the code base.
SCIF
reviewed
Nov 26, 2017
|
|
||
| $extension->load($config, $tmpContainer); | ||
| $extension->load($config, $tmpContainer); | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
Any chance to specify less general exception?
There was a problem hiding this comment.
Would be a bug. Could be "finally" in fact.
nicolas-grekas
added a commit
that referenced
this pull request
Nov 27, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [DI] Fix tracking of env vars in exceptions | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24270, #24368 | License | MIT | Doc PR | - Fixes the bad exception message reported in the linked issue (regression introduced in v3.3.7). Best reviewed [ignoring whitespaces](https://github.com/symfony/symfony/pull/25163/files?w=1). Commits ------- 73f1ac5 [DI] Fix tracking of env vars in exceptions
This was referenced Nov 30, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bad exception message reported in the linked issue (regression introduced in v3.3.7).
Best reviewed ignoring whitespaces.