[WebProfilerBundle] Reset letter-spacing in toolbar #25140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Nov 24, 2017
javiereguiluz
approved these changes
Nov 24, 2017
|
Is 3.4 the right branch to merge this? If this considered a bug, then it should be 2.7. |
|
I think it should be 3.3 actually; i targeted the new profiler only. Not sure we should patch 2.7 toolbar in any non-security related way. |
|
Can you please change the branch to 3.3? Thanks. |
|
way ahead of you :) |
|
Thanks Roland. |
javiereguiluz
added a commit
that referenced
this pull request
Nov 24, 2017
This PR was merged into the 3.3 branch.
Discussion
----------
[WebProfilerBundle] Reset letter-spacing in toolbar
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Test
8000
s pass? | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->
Somewhere in our project we have
```scss
*,
*:before,
*:after {
letter-spacing: 1px;
box-sizing: border-box;
}
```
affecting the toolbar
<details>
<summary>before</summary>
</details>
<details>
<summary>after</summary>
</details>
Commits
-------
bef2618 [WebProfilerBundle] Reset letter-spacing in toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere in our project we have
affecting the toolbar
before
after