[TwigBundle] Exception page: prefer overflow-wrap to word-break #25138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 24, 2017
fabpot
approved these changes
Nov 24, 2017
|
Thank you @julienfalque. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2017
…d-break (julienfalque) This PR was merged into the 3.3 branch. Discussion ---------- [TwigBundle] Exception page: prefer overflow-wrap to word-break | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes-ish | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This prevents arbitrary text wrapping, breaks are always made on whitespace when possible: **Before**  **After**  Random breaks inside words can still be made for very long words: **Before**  **After**  Tested on Chrome 62 (Linux) and Firefox 47 (Linux). Commits ------- c7333b1 Prefer overflow-wrap to word-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents arbitrary text wrapping, breaks are always made on whitespace when possible:
Before
After
Random breaks inside words can still be made for very long words:
Before
After
Tested on Chrome 62 (Linux) and Firefox 47 (Linux).