8000 [TwigBridge] Pass the form-check-inline in parent by Simperfit · Pull Request #25127 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[TwigBridge] Pass the form-check-inline in parent #25127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Simperfit
Copy link
Contributor
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #25099
License MIT
Doc PR none

I'm trying to find a way to be able to handle this. Will add a reproducer soon.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 23, 2017
@Simperfit Simperfit changed the title [TwigBridge][WIP] Pass the form-check-inline in parent [TwigBridge] Pass the form-check-inline in parent Nov 28, 2017
@Nyholm
Copy link
Member
Nyholm commented Nov 30, 2017

The result seams fine according to: https://v4-alpha.getbootstrap.com/components/forms/#inline

@Simperfit
Copy link
Contributor Author
Simperfit commented Dec 8, 2017

Status: Needs Review

@fabpot
Copy link
Member
fabpot commented Jan 17, 2018

Thank you @Simperfit.

@fabpot fabpot merged commit 02b7edb into symfony:3.4 Jan 17, 2018
fabpot added a commit that referenced this pull request Jan 17, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] Pass the form-check-inline in parent

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | no
| Fixed tickets | #25099 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none

I'm trying to find a way to be able to handle this. Will add a reproducer soon.

Commits
-------

02b7edb [TwigBridge][WIP] Pass the form-check-inline in parent
This was referenced Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0