8000 [Security] #25091 add target user to SwitchUserListener by jwmickey · Pull Request #25092 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] #25091 add target user to SwitchUserListener #25092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[Security] #25091 add target user to SwitchUserListener #25092

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e7fd42
[Security] #25091 add user to SwitchUserListener
jwmickey Nov 21, 2017
730fd82
pull-request reworks
jwmickey Nov 25, 2017
ade9e2a
fixed issue where username would be overwritten
jwmickey Nov 26, 2017
4acccfd
Re-added empty line before throw statement
jwmickey Dec 13, 2017
1acab4a
Update SwitchUserListener.php
jwmickey Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pull-request reworks 
- moved message from the general changelog to the security component's
changelog
- restored exception attributes that were mistakenly removed
  • Loading branch information
@jwmickey
jwmickey committed Nov 27, 2017
commit 730fd827145d0d40c9050a14852c166aa698b1fe
2 changes: 0 additions & 2 deletions CHANGELOG-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
CHANGELOG for 4.0.x
===================

* feature #25091 [Security] Add target user to SwitchUserListener (jwmickey)

This changelog references the relevant changes (bug and security fixes) done
in 4.0 minor versions.

Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Security/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ CHANGELOG
* removed HTTP digest authentication
* removed `GuardAuthenticatorInterface` in favor of `AuthenticatorInterface`
* removed `AbstractGuardAuthenticator::supports()`
* added target user to `SwitchUserListener`

3.4.0
-----
Expand Down
4 changes: 3 additions & 1 deletion src/Symfony/Component/Security/Http/Firewall/SwitchUserListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ private function attemptSwitchUser(Request $request, $username)
$user = $this->provider->loadUserByUsername($username);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change should be reverted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this change be reverted?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't follow. Are you saying that the $user param does not need to be passed to the accessDecisionManager->decide() call as the 3rd parameter?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a misunderstanding then. I was just referring to the blank line which should not have been removed.

if (false === $this->accessDecisionManager->decide($token, array($this->role), $user)) {
throw new AccessDeniedException();
$exception = new AccessDeniedException();
$exception->setAttributes($this->role);
throw $exception;
}

if (null !== $thi 4187 s->logger) {
Expand Down
0