8000 Allow EnumNode name to be null by MatTheCat · Pull Request #25048 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Allow EnumNode name to be null #25048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Allow EnumNode name to be null #25048

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42269df
Allow EnumNode name to be null
Nov 20, 2017
0cb1988
add test case
Nov 20, 2017
ea05224
Finalize node
Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
8000
Diff view
Diff view
Prev Previous commit
Finalize node
  • Loading branch information
Mathieu Lechat committed Nov 20, 2017
commit ea05224f9e5f3e8f240c1e7051d965d1b99cc4ed
3 changes: 2 additions & 1 deletion src/Symfony/Component/Config/Tests/Definition/EnumNodeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ public function testConstructionWithOneDistinctValue()

public function testConstructionWithNullName()
{
new EnumNode(null, null, array('foo'));
$node = new EnumNode(null, null, array('foo'));
$this->assertSame('foo', $node->finalize('foo'));
}

/**
Expand Down
0