8000 [SecurityBundle] Don't trigger auto-picking notice if provider is set per listener by chalasr · Pull Request #25045 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] Don't trigger auto-picking notice if provider is set per listener #25045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2017
Merged

[SecurityBundle] Don't trigger auto-picking notice if provider is set per listener #25045

merged 1 commit into from
Nov 20, 2017

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Nov 20, 2017
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24980
License MIT
Doc PR n/a

@chalasr chalasr added this to the 3.4 milestone Nov 20, 2017
@chalasr chalasr mentioned this pull request Nov 20, 2017
Closed
@xabbuh
Copy link
Member
xabbuh commented Nov 20, 2017

I would add a test case with a config like the one provided in the linked issue to prevent regressions.

@chalasr chalasr force-pushed the provider-guessing-deprec branch from 792f258 to 19e891a Compare November 20, 2017 11:33
@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 19e891a into symfony:3.4 Nov 20, 2017
nicolas-grekas added a commit that referenced this pull request Nov 20, 2017
@nicolas-grekas
bug #25045 [SecurityBundle] Don't trigger auto-picking notice if prov…
e3efa2f 
…ider is set per listener (chalasr)

This PR was merged into the 3.4 branch.

Discussion
----------

[SecurityBundle] Don't trigger auto-picking notice if provider is set per listener

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24980
| License       | MIT
| Doc PR        | n/a

Commits
-------

19e891a [SecurityBundle] Don't trigger auto-picking notice if provider is set per listener
@chalasr chalasr deleted the provider-guessing-deprec branch November 20, 2017 18:24
This was referenced Nov 21, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@chalasr @xabbuh @nicolas-grekas @ogizanagi @Simperfit @carsonbot
0