[Bridge\PhpUnit] Disable broken auto-require mechanism of phpunit #25032
+47
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af081f3 to
0577d20
Compare
|
moved to 3.3 to prevent conflicts between local and vendor phpunit bridges |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 19, 2017
…phpunit (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Bridge\PhpUnit] Disable broken auto-require mechanism of phpunit | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25017 | License | MIT | Doc PR | - It took me all the flight back from Cluj to figure out this is the only way to solve this nasty issue created by phpunit generating inlined `require_once` in the global scope for isolated tests. This mechanism predates the autoloading mechanism, and it's behavior is just hardcoded. Needs to be merged in 3.4, where the split container triggers this situation very quickly. Will allow removing the `function_exists('__phpunit_run_isolated_test')` workarounds already in place in the code base (2.7 up to master.) Commits ------- 0577d20 [Bridge\PhpUnit] Disable broken auto-require mechanism of phpunit
nicolas-grekas
added a commit
that referenced
this pull request
Nov 19, 2017
…ks (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- Remove function_exists(__phpunit_run_isolated_test) checks | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As now permitted by #25032 Commits ------- a512217 Remove function_exists(__phpunit_run_isolated_test) checks
|
I'm getting since upgrading to the latest 3.4. Not entirely sure it's related yet. UPDATE: I have the same issue with 3.x, I'll try bisecting. |
|
0577d20 is the first bad commit |
|
did you remove the |
|
I just tried removing |
|
Here is a simple reproducer: |
|
@greg0ire can you try again? could/should be fixed. |
|
No luck it seems, with both the phar and simple-phpunit (with |
|
ok, then I need a reproducer that actually works :) |
|
Here you go: Not sure why this can't be reproduced easily 😅 |
|
@greg0ire OK, actually that's a bug in Sonata's tests/bootstrap.php: |
|
Thanks a lot for the diagnosis, sorry we had that weird stuff, we're going to simplify. Cc @soullivaneuh @core23 @OskarStark @jordisala1991 @jlamur |
Merged
|
So there is no other way than to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me all the flight back from Cluj to figure out this is the only way to solve this nasty issue created by phpunit generating inlined
require_oncein the global scope for isolated tests.This mechanism predates the autoloading mechanism, and it's behavior is just hardcoded.
Needs to be merged in 3.4, where the split container triggers this situation very quickly.
Will allow removing the
function_exists('__phpunit_run_isolated_test')workarounds already in place in the code base (2.7 up to master.)