8000 [Console] Remove remaining dead code by chalasr · Pull Request #25008 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Remove remaining dead code #25008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2017
Merged

[Console] Remove remaining dead code #25008

merged 1 commit into from
Nov 18, 2017

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Nov 17, 2017
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Since they are always re-thrown, no need to catch \Error instances at all.

@chalasr chalasr requested a review from Tobion November 17, 2017 13:01
@chalasr chalasr added this to the 2.7 milestone Nov 17, 2017
@Tobion
Copy link
Contributor
Tobion commented Nov 17, 2017

Works as well. People might just be tempted to introduce catching throwables again as they might think it's missing accidentally. But I guess we have a test for this..

@fabpot
Copy link
Member
fabpot commented Nov 18, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 3822c07 into symfony:2.7 Nov 18, 2017
fabpot added a commit that referenced this pull request Nov 18, 2017
@fabpot
minor #25008 [Console] Remove remaining dead code (chalasr)
9447016 
This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Remove remaining dead code

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Since they are always re-thrown, no need to catch `\Error` instances at all.

Commits
-------

3822c07 [Console] Remove remaining dead code
@chalasr chalasr deleted the console-dead-code branch November 19, 2017 16:38
@chalasr
Copy link
Member Author
chalasr commented Nov 19, 2017

@Tobion yes that's covered https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Tests/ApplicationTest.php#L1224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Tobion Tobion Tobion approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
5319
Labels
Console Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@chalasr @Tobion @fabpot @xabbuh @carsonbot
0