[Filesystem] Replace remaing docblocks by type-hints #24926
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return \Traversable | ||
| */ | ||
| private function toIterator($files) | ||
| private function toIterable($files): iterable |
Member
There was a problem hiding this comment.
the name change is debatable, and creates useless diff lines, thus won't help merges
should be reverted IMHO
| } | ||
|
|
||
| return $files; | ||
| return is_iterable($files) ? $files : array($files); |
Member
There was a problem hiding this comment.
this implementation is not compatible with the previous, won't it create BC breaks f the return is forwarded as return value of a public method?
Contributor
Author
There was a problem hiding this comment.
private API :) checked all usages; they truly rely on a foreachable value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially forgotten in #24722 as only
private getSchemeAndHierarchywas updated.Adds simplification of
toIterator.edit: wrong labels.