[HttpFoundation] Prevent PHP from sending Last-Modified on session start #24878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
reviewed
Nov 9, 2017
| @@ -32,6 +32,9 @@ | |||
| public function open($savePath, $sessionName) | |||
| { | |||
| $this->sessionName = $sessionName; | |||
| if (!headers_sent() && !ini_get('session.cache_limiter')) { | |||
There was a problem hiding this comment.
Shouldn't we raise a warning or something in !ini_get('session.cache_limiter') && headers_sent() ?
There was a problem hiding this comment.
not sure, there are many similar checks in the code base already
There was a problem hiding this comment.
Well, this one convinced me... 😅
fabpot
approved these changes
Nov 9, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 9, 2017
… session start (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Prevent PHP from sending Last-Modified on session start | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24849 | License | MIT | Doc PR | - I really don't know why PHP sends this Last-Modified header. Let's bypass that and throw headers ourselves instead. Commits ------- 2c0dc74 [HttpFoundation] Prevent PHP from sending Last-Modified on session start
Tobion
reviewed
Nov 10, 2017
| @@ -107,7 +107,7 @@ public function __construct(array $options = array(), $handler = null, MetadataB | |||
| } | |||
|
|
|||
| $options += array( | |||
| 'cache_limiter' => 'private_no_expire', | |||
| 'cache_limiter' => '', | |||
There was a problem hiding this comment.
the phpdoc with the standard options is wrong now
This was referenced Nov 12, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really don't know why PHP sends this Last-Modified header.
Let's bypass that and throw headers ourselves instead.