[YAML] Allow to parse custom tags when linting yaml files #24870
Conversation
a0665a3 to
277dddf
Compare
277dddf to
59651f7
Compare
|
Since the tag parsing feature is opt-in it may be worth it to make at an opt-in feature of the lint command too. |
|
I did initially add a new option to the command to enable the flag, but wasn't sure if that would count as a new feature then instead of a bug fix? |
|
Seems like a feature yes, although it should have been added at time the constant has been introduced. |
|
Linting the yaml files is part of our build process, so all our builds keeps failing because of this. So if this can only go in as a new feature in 4.1, then we won't be able to lint yaml files until May next year and after upgrading to Symfony 4 (or we must duplicate the logic in our application) unless this can be enabled by default without the additional option, but that might cause some false-positives if someone hasn't enabled custom tags |
|
Thank you @pierredup. |
…(pierredup) This PR was squashed before being merged into the 3.3 branch (closes #24870). Discussion ---------- [YAML] Allow to parse custom tags when linting yaml files | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A When using custom tags in yaml, currently the `lint:yaml` command fails since the flag `Yaml::PARSE_CUSTOM_TAGS` is not passed through Commits ------- d8dd91d [YAML] Allow to parse custom tags when linting yaml files
When using custom tags in yaml, currently the
lint:yamlcommand fails since the flagYaml::PARSE_CUSTOM_TAGSis not passed through