8000 [FrameworkBundle] Add default mapping path for validator component in bundle-less app by yceruto · Pull Request #24856 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Add default mapping path for validator component in bundle-less app #24856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2017
Merged

[FrameworkBundle] Add default mapping path for validator component in bundle-less app #24856

merged 1 commit into from
Nov 10, 2017

Conversation

yceruto
Copy link
Member
@yceruto yceruto commented Nov 7, 2017 •
edited
Loading
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR ToDo

Same approach of #24833

@yceruto yceruto changed the title Add default mapping path for validator component [FrameworkBundle] Add default mapping path for validator component Nov 7, 2017
@yceruto yceruto mentioned this pull request Nov 7, 2017
Merged
@yceruto yceruto changed the title [FrameworkBundle] Add default mapping path for validator component [FrameworkBundle] Add default mapping path for validator component in bundle-less app Nov 7, 2017
@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Nov 7, 2017
@nicolas-grekas
Copy link
Member

For 3.4?

@yceruto yceruto changed the base branch from master to 3.4 November 7, 2017 13:54
@yceruto
Cop 8000 y link
Member Author
yceruto commented Nov 7, 2017

@nicolas-grekas I guess yes, same opinion of @dunglas #24833 (review)

Rebased to 3.4

@fabpot
Copy link
Member
fabpot commented Nov 10, 2017

Thank you @yceruto.

@fabpot fabpot merged commit 4e0daec into symfony:3.4 Nov 10, 2017
fabpot added a commit that referenced this pull request Nov 10, 2017
@fabpot
bug #24856 [FrameworkBundle] Add default mapping path for validator c…
c549e3c 
…omponent in bundle-less app (yceruto)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Add default mapping path for validator component in bundle-less app

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | ToDo

Same approach of #24833

Commits
-------

4e0daec Add default mapping path for validator component
@yceruto yceruto deleted the validator_path branch November 10, 2017 19:19
This was referenced Nov 12, 2017
Merged
Merged
@yceruto yceruto mentioned this pull request Nov 13, 2017
Merged
weaverryan added a commit to symfony/symfony-docs that referenced this pull request Nov 16, 2017
@weaverryan
minor #8633 Add new validator config & translations path (yceruto)
3bdb916 
This PR was merged into the master branch.

Discussion
----------

Add new validator config & translations path

See symfony/symfony#24856

Commits
-------

a953fc0 Add new validator config & translations path
@yceruto yceruto mentioned this pull request Nov 21, 2017
Closed
@yceruto yceruto mentioned this pull request Nov 29, 2017
Closed
@strawburrypokki
Copy link

Hello, quick question.
I've noticed that the default path for validation metadata file is in $projectDir.'/config/validator' directory (eg. /home/sf_project/config/validator/).

Is it deliberate? What about Sf3 directory structure and the app/config directory (eg. /home/sf_project/app/config/validator)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@yceruto @nicolas-grekas @fabpot @strawburrypokki @carsonbot
0