8000 [DI] Fix cannot bind env var by ogizanagi · Pull Request #24850 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Fix cannot bind env var #24850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2017
Merged

[DI] Fix cannot bind env var #24850

merged 1 commit into from
Nov 7, 2017

Conversation

ogizanagi
Copy link
Contributor
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24845
License MIT
Doc PR N/A

In #24602 we removed the processing of bindings from the AbstractRecursivePass. But there is actually one case where we want a recursive pass to process them: to resolve env param placeholders.

@ogizanagi ogizanagi mentioned this pull request Nov 7, 2017
Closed
sroze
sroze approved these changes Nov 7, 2017
View reviewed changes
Copy link
Contributor
@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 7, 2017
@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit f8f3a15 into symfony:3.4 Nov 7, 2017
nicolas-grekas added a commit that referenced this pull request Nov 7, 2017
@nicolas-grekas
bug #24850 [DI] Fix cannot bind env var (ogizanagi)
b2edd51 
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix cannot bind env var

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #24845 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

In #24602 we removed the processing of bindings from the `AbstractRecursivePass`. But there is actually one case where we want a recursive pass to process them: to resolve env param placeholders.

Commits
-------

f8f3a15 [DI] Fix cannot bind env var
@ogizanagi ogizanagi deleted the fix/3.4/bind_env_var branch November 7, 2017 15:43
This was referenced Nov 12, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

@sroze sroze sroze approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@ogizanagi @nicolas-grekas @stof @sroze @chalasr @carsonbot
0