8000 Fix some signatures in PHP-DSLs by nicolas-grekas · Pull Request #24846 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix some signatures in PHP-DSLs #24846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Fix some signatures in PHP-DSLs #24846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix some signatures in PHP-DSLs
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Nov 6, 2017
commit af8543107a6a0b67dc5a5b656ab7d0152293c7de
6 changes: 3 additions & 3 deletions src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class ContainerConfigurator extends AbstractConfigurator
private $path;
private $file;

public function __construct(ContainerBuilder $container, PhpFileLoader $loader, &$instanceof, $path, $file)
public function __construct(ContainerBuilder $container, PhpFileLoader $loader, array &$instanceof, $path, $file)
{
$this->container = $container;
$this->loader = $loader;
Expand Down Expand Up @@ -66,15 +66,15 @@ final public function import($resource, $type = null, $ignoreErrors = false)
/**
* @return ParametersConfigurator
*/
public function parameters()
final public function parameters()
{
return new ParametersConfigurator($this->container);
}

/**
* @return ServicesConfigurator
*/
public function services()
final public function services()
{
return new ServicesConfigurator($this->container, $this->loader, $this->instanceof);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/DependencyInjection/Loader/Configurator/ServicesConfigurator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function __construct(ContainerBuilder $container, PhpFileLoader $loader,
*
* @return DefaultsConfigurator
*/
public function defaults()
final public function defaults()
{
return new DefaultsConfigurator($this, $this->defaults = new Definition());
}
Expand Down
6 changes: 0 additions & 6 deletions src/Symfony/Component/Routing/Loader/Configurator/Traits/RouteTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ trait RouteTrait
/**
* Adds defaults.
*
* @param array $defaults
*
* @return $this
*/
final public function defaults(array $defaults)
Expand All @@ -38,8 +36,6 @@ final public function defaults(array $defaults)
/**
* Adds requirements.
*
* @param array $requirements
*
* @return $this
*/
final public function requirements(array $requirements)
Expand All @@ -52,8 +48,6 @@ final public function requirements(array $requirements)
/**
* Adds options.
*
* @param array $options
*
* @return $this
*/
final public function options(array $options)
Expand Down
0