8000 [Intl] Make intl-data tests pass and save language aliases again by jakzal · Pull Request #24814 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Intl] Make intl-data tests pass and save language aliases again #24814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Intl] Make intl-data tests pass and save language aliases again #24814

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3366277
[Intl] Make intl-data tests pass again
jakzal Oct 27, 2017
b15ea8d
[Intl] Save language aliases again
jakzal Nov 3, 2017
a1a551d
[Intl] Update assertions to verify data is not empty
jakzal Nov 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Intl] Update assertions to verify data is not empty
  • Loading branch information
@jakzal
jakzal committed Nov 4, 2017
commit a1a551ddbd86298426cd6579f804dd85d4813eae
1 change: 1 addition & 0 deletions src/Symfony/Component/Intl/Tests/Data/Provider/AbstractLanguageDataProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,6 +856,7 @@ public function testGetNames($displayLocale)

sort($languages);

$this->assertNotEmpty($languages);
$this->assertEmpty(array_diff($languages, static::$languages));
}

Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Intl/Tests/Data/Provider/AbstractLocaleDataProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public function testGetNames($displayLocale)

// We can't assert on exact list of locale, as there's too many variations.
// The best we can do is to make sure getNames() returns a subset of what getLocales() returns.
$this->assertNotEmpty($locales);
$this->assertEmpty(array_diff($locales, $this->getLocales()));
}

Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Intl/Tests/Data/Provider/AbstractScriptDataProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ public function testGetNames($displayLocale)

// We can't assert on exact list of scripts, as there's too many variations between locales.
// The best we can do is to make sure getNames() returns a subset of what getScripts() returns.
$this->assertNotEmpty($scripts);
$this->assertEmpty(array_diff($scripts, self::$scripts));
}

Expand Down
0