8000 [Config] Fix dump of config references for deprecated nodes by chalasr · Pull Request #24809 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Fix dump of config references for deprecated nodes #24809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2017
Merged

[Config] Fix dump of config references for deprecated nodes #24809

merged 1 commit into from
Nov 3, 2017

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Nov 3, 2017
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a 
# before
trusted_proxies:      [] # Deprecated (The "framework.trusted_proxies.trusted_proxies" configuration key has been deprecated in Symfony 3.3. Use the Request::setTrustedProxies() method in your front controller instead.)

#after
trusted_proxies:      [] # Deprecated (The "framework.trusted_proxies" configuration key has been deprecated in Symfony 3.3. Use the Request::setTrustedProxies() method in your front controller instead.)

@chalasr chalasr added this to the 3.4 milestone Nov 3, 2017
@fabpot
Copy link
Member
fabpot commented Nov 3, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 188eb34 into symfony:3.4 Nov 3, 2017
fabpot added a commit that referenced this pull request Nov 3, 2017
@fabpot
bug #24809 [Config] Fix dump of config references for deprecated node…
e973c24 
…s (chalasr)

This PR was merged into the 3.4 branch.

Discussion
----------

[Config] Fix dump of config references for deprecated nodes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

```yaml
# before
trusted_proxies:      [] # Deprecated (The "framework.trusted_proxies.trusted_proxies" configuration key has been deprecated in Symfony 3.3. Use the Request::setTrustedProxies() method in your front controller instead.)

#after
trusted_proxies:      [] # Deprecated (The "framework.trusted_proxies" configuration key has been deprecated in Symfony 3.3. Use the Request::setTrustedProxies() method in your front controller instead.)
```

Commits
-------

188eb34 Fix reference dump for deprecated nodes
@chalasr chalasr deleted the deprecated-node-dump branch November 3, 2017 14:46
This was referenced Nov 5, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Config Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @fabpot @carsonbot
0