8000 [TwigBundle] Added priority to twig extensions by Brunty · Pull Request #24777 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBundle] Added priority to twig extensions #24777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

[TwigBundle] Added priority to twig extensions #24777

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9658556
[TwigBundle] Added priority to twig extensions
Brunty Oct 31, 2017
65cc813
[TwigBundle] Refactor to PriorityTaggedServiceTrait
Brunty Nov 1, 2017
0d77f49
[TwigBundle] Refactor extension variable as already a reference
Brunty Nov 1, 2017
54d30b1
[TwigBundle] Remove unused use statement
Brunty Nov 2, 2017
3d5a545
[TwigBundle] Add changelog entry for priority on extensions
Brunty Nov 18, 2017
1cf78d2
[TwigBundle] Move changelog entry to 4.1.0
Brunty Dec 29, 2017
a22d713
[TwigBundle] Fix capitalisation in changelog
Brunty Jan 2, 2018
65f4e89
[TwigBundle] Remove mock container builder in test
Brunty Jan 2, 2018
a00ffad
[TwigBundle] Fix code style errors
Brunty Jan 2, 2018
ff2aba2
[TwigBundle] Update changelog for newline formatting
Brunty Jan 16, 2018
9e8d1f5
[TwigBundle] Remove TwigEngironmentPassTest setUp method
Brunty Jan 16, 2018
5399083
[TwigBundle] Fix code style in TwigEnvironmentPassTest
Brunty Jan 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[TwigBundle] Remove TwigEngironmentPassTest setUp method 
Moves the properties on the test class to variables inside the single test method it has.
  • Loading branch information
@Brunty
Brunty committed Jan 16, 2018
commit 9e8d1f5107cc39a2ede42029cba0d4c74fcbe5b2
36 changes: 10 additions & 26 deletions src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/Compiler/TwigEnvironmentPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,41 +18,25 @@

class TwigEnvironmentPassTest extends TestCase
{
/**
* @var ContainerBuilder
*/
private $builder;
/**
* @var Definition
*/
private $definition;
/**
* @var TwigEnvironmentPass
*/
private $pass;

protected function setUp()
{
$this->builder = new ContainerBuilder();
$this->definition = new Definition('twig');
$this->definition->setPublic(true);
$this->builder->setDefinition('twig', $this->definition);

$this->pass = new TwigEnvironmentPass();
}

public function testPassWithTwoExtensionsWithPriority()
{
$twigDefinition = new Definition('twig');
$twigDefinition->setPublic(true);
$builder = new ContainerBuilder();
$builder->setDefinition('twig', $twigDefinition);
$pass = new TwigEnvironmentPass();

$definition = new Definition('test_extension_1');
$definition->addTag('twig.extension', array('priority' => 100));
$this->builder->setDefinition('test_extension_1', $definition);
$builder->setDefinition('test_extension_1', $definition);

$definition = new Definition('test_extension_2');
$definition->addTag('twig.extension', array('priority' => 200));
$this->builder->setDefinition('test_extension_2', $definition);
$builder->setDefinition('test_extension_2', $definition);

$this->pass->process($this->builder);
$calls = $this->definition->getMethodCalls();
$pass->process($builder);
$calls = $twigDefinition->getMethodCalls();
$this->assertCount(2, $calls);
$this->assertEquals('addExtension', $calls[0][0]);
$this->assertEquals('addExtension', $calls[1][0]);
Expand Down
0