8000 [VarDumper] Fix DST bug by maidmaid · Pull Request #24752 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] Fix DST bug #24752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2017
Merged

[VarDumper] Fix DST bug #24752

merged 1 commit into from
Oct 30, 2017

Conversation

maidmaid
Copy link
Contributor
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24749
License MIT
Doc PR /

@maidmaid
Copy link
Contributor Author

ping @nicolas-grekas The tests work with DST now.

@fabpot
Copy link
Member
fabpot commented Oct 30, 2017

Thank you @maidmaid.

@fabpot fabpot merged commit e375e9a into symfony:3.4 Oct 30, 2017
fabpot added a commit that referenced this pull request Oct 30, 2017
@fabpot
minor #24752 [VarDumper] Fix DST bug (maidmaid)
344e4b0 
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] Fix DST bug

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24749
| License       | MIT
| Doc PR        | /

Commits
-------

e375e9a Fix DST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed VarDumper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maidmaid @fabpot @javiereguiluz @Simperfit @carsonbot
0